Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TagPanel from collapsing to < 60px when LP collapsed #6134

Merged
merged 2 commits into from
Feb 13, 2018
Merged

Fix TagPanel from collapsing to < 60px when LP collapsed #6134

merged 2 commits into from
Feb 13, 2018

Conversation

lukebarnard1
Copy link
Contributor

Fixes #6133

@ara4n
Copy link
Member

ara4n commented Feb 13, 2018

this ignores layouts where TagPanel is hidden, but is otherwise okay - going to merge it in the hope that it will provide a better solution to the horrid mess in #6136

@ara4n ara4n merged commit 7aea7f9 into develop Feb 13, 2018
@ara4n ara4n mentioned this pull request Feb 13, 2018
Closed
lukebarnard1 added a commit that referenced this pull request Feb 14, 2018
@lukebarnard1
Fix LeftPanel size being incorrect when TagPanel disabled
009e01c 
A previous PR (#6134) assumed that the TagPanel feature
would always be enabled, leading to strangeness when it
wasn't: #6136.

(FTR the original layout bug was #6133)
@lukebarnard1 lukebarnard1 mentioned this pull request Feb 14, 2018
Merged
@t3chguy t3chguy deleted the luke/fix-tag-panel-collapse branch May 12, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ara4n ara4n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebarnard1 @ara4n