Implement renumeration of ordered tags upon collision #5759
+20
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was being bitten by this enough for me to want to fix it. This implementation really ought to be improved such that it doesnt tend towards being broken the more it is used.
|
@ara4n this is probably one for you |
|
lgtm! embarrassing how easy the end soln was :S |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was being bitten by this enough for me to want to fix it. This implementation really ought to be improved such that it doesn't tend towards being broken the more it is used.
I'm not convinced we should be trusting that the client has the correct state in it (and is therefore in a position to calculate a new
order). If a different implementation didn't rely on the client having the correct client state, then let's do that.One example would be to do a linked list where the tag on the room refers to the previously tagged room. This however has the potential for error if the client removes an item and then fails to reinsert it. This is probably a better weirdness than what we have currently, though.