CSS for new TagPanel #5723
CSS for new TagPanel #5723
Conversation
| @@ -33,14 +33,13 @@ limitations under the License. | |||
| font-weight: 600; | |||
| font-size: 12px; | |||
| width: 203px; /* padding + width = LHS Panel width */ | |||
| height: 17px; /* padding + height = 29px, same as mx_RoomSubList_stickyContainer */ | |||
| height: 19px; /* padding + height = 29px, same as mx_RoomSubList_stickyContainer */ | |||
There was a problem hiding this comment.
You're replacing the 2px border with an extra 2px of height? What's the reason for doing so? And could we update the comment too, otherwise it becomes a lie since 19 + (6 * 2) != 29
There was a problem hiding this comment.
Yep, this seemed the easiest option, without the border or height there would be gaps between the "stuck" headers. Increasing the height is one option, another would have been leaving the border and colouring it the same as the background but that seemed a bit pointless.
I shall comment as such. mx_RoomSubList_stickyContainer doesn't exist so I'll probably just remove the comment.
There was a problem hiding this comment.
I realised it should have been
/* height + padding = 31px = mx_RoomSubList_label height */
There was a problem hiding this comment.
ok, yeah, I think that makes sense!
|
Tests have flaked, surprise surprise |
For matrix-org/matrix-react-sdk#1639