Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set padding-bottom: 0px for .mx_Dialog spinner #3351

Merged
merged 2 commits into from
Mar 3, 2017
Merged

Set padding-bottom: 0px for .mx_Dialog spinner #3351

merged 2 commits into from
Mar 3, 2017

Conversation

lukebarnard1
Copy link
Contributor

This was causing #3226

@ara4n
Copy link
Member

ara4n commented Mar 3, 2017

it seems very strange it was ever special-casing the left edge. why wouldn't this be padding: 0px?

@ara4n ara4n assigned lukebarnard1 and unassigned ara4n Mar 3, 2017
@lukebarnard1
Copy link
Contributor Author

lukebarnard1 commented Mar 3, 2017 •
edited
Loading

@ara4n padding: 0px would make far more sense, and works in practice. Strange indeed!

@lukebarnard1 lukebarnard1 assigned ara4n and unassigned lukebarnard1 Mar 3, 2017
@ara4n
Copy link
Member

ara4n commented Mar 3, 2017

lgtm!

@lukebarnard1 lukebarnard1 merged commit b1f14ba into develop Mar 3, 2017
@t3chguy t3chguy deleted the luke/css-spinner-height branch May 12, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ara4n ara4n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebarnard1 @ara4n