Update desktop build instructions fixes #2792 #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on what I had to do to get the desktop app running, as per the advice in #2792. I am not familiar with `npm`, so please change this pull request if there is a more appropriate way of achieving the same result.
|
oops - thanks for this!! |
|
i'll merge to master and cherrypick to develop. |
andreygursky
added a commit
to andreygursky/riot-web
that referenced
this pull request
Feb 16, 2017
Fixes element-hq#2793 again after regression 3c91f90
andreygursky
added a commit
to andreygursky/riot-web
that referenced
this pull request
Feb 16, 2017
Fixes element-hq#2793 again after regression 3c91f90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on what I had to do to get the desktop app running, as per the advice in #2792. I am not familiar with
npm, so please change this pull request if there is a more appropriate way of achieving the same result.