Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login loop where the sso flow returns to #/login #13889

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 2, 2020

due to fragmentAfterLogin going back to #/login and #11643
Requires matrix-org/matrix-react-sdk#4685

due to fragmentAfterLogin going back to `#/login`
and #11643

Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy requested a review from a team June 2, 2020 15:45
@t3chguy
Copy link
Member Author

t3chguy commented Jun 2, 2020

needs merging in lock-step with other PR for tests to pass as the branch matching thing doesn't apply to all our test jobs :'(

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - see review on other half

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants