Update electron to v7.1.14 #12762
Merged
Update electron to v7.1.14 #12762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependency to electron version 7.1.4 to resolve issue where riot-web has troubles syncing messages, and throws a "**CRASHING**:seccomp-bpf failure in syscall 0230" error. See electron/electron#22291 for more details.
|
Thanks for the contribution! Can we get sign off per our contributing guidelines please? Just need to leave a comment with: |
|
Signed-off-by: Jared Smith [email protected] |
jryans
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
Thanks, this looks good to me!
I noticed that 7.1.14 also fixes will-navigate events in the 7.x series, which is something that caused us to downgrade from 8.x previously, but after chatting with @t3chguy on this, it sounds like those issues are sorted and it's safe to have this event come through again.
t3chguy
added a commit
that referenced
this pull request
Oct 17, 2024
…12762) Signed-off-by: Michael Telatynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependency to electron version 7.1.14 to resolve issue where riot-web
has troubles syncing messages, and throws a "CRASHING:seccomp-bpf
failure in syscall 0230" error.
See electron/electron#22291 for more details.