Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BuildKite: Only deploy to /develop if everything else passed #11996

Merged
merged 1 commit into from
Jan 22, 2020
Merged

BuildKite: Only deploy to /develop if everything else passed #11996

merged 1 commit into from
Jan 22, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 22, 2020 •
edited
Loading

Fixes #11866

Described as an implicit dependency to simplify adding more stages later

@t3chguy t3chguy requested a review from a team January 22, 2020 15:06
turt2live
turt2live approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good enough for now

@t3chguy
Copy link
Member Author

t3chguy commented Jan 22, 2020

good enough for now

Whats the ideal fix here?

@t3chguy t3chguy merged commit 8d769da into develop Jan 22, 2020
@t3chguy t3chguy deleted the t3chguy/buildkite branch May 12, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We deploy to /develop even when the tests fail
2 participants
@t3chguy @turt2live