Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactions: Encrypt aggregation key in E2E rooms #9672

Closed
jryans opened this issue May 10, 2019 · 2 comments
Closed

Reactions: Encrypt aggregation key in E2E rooms #9672

jryans opened this issue May 10, 2019 · 2 comments
Labels
A-Aggregations A-Reactions T-Enhancement

Comments

@jryans
Copy link
Collaborator

jryans commented May 10, 2019

The aggregation key / reaction value should be encrypted using the message key of the original event being reacted to.
@jryans jryans self-assigned this May 13, 2019
This was referenced May 15, 2019
Merged
Merged
@jryans jryans added phase:2 and removed phase:1 labels May 16, 2019
@jryans jryans removed their assignment May 16, 2019
@jryans jryans added phase:3 and removed phase:2 labels Jun 12, 2019
@jryans
Copy link
Collaborator Author

jryans commented Jun 12, 2019 •
edited
Loading

This is no longer required for shipping reactions. We plan to add metadata to the encrypted aggregation keys so that it's clear to the client when they do need decryption.

@jryans jryans mentioned this issue Jun 20, 2019
Closed
@lampholder lampholder added phase:4 and removed phase:3 labels Jul 2, 2019
@turt2live
Copy link
Member

This is a spec issue, for which I believe an issue already exists (or at least a comment on the STILL unmerged MSC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Aggregations A-Reactions T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jryans @turt2live @lampholder