Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Prevention of [some] RoomList Regressions #6315

Closed
lukebarnard1 opened this issue Mar 14, 2018 · 4 comments
Closed

Tests for Prevention of [some] RoomList Regressions #6315

lukebarnard1 opened this issue Mar 14, 2018 · 4 comments
Assignees
Labels
P1 T-Task Tasks for the team like planning

Comments

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 14, 2018

In order to have some degree of confidence in merging:

, the plan is to write a few tests to make sure RoomTiles and RoomSublists are updating correctly in response to app state changing. To be clear, the following tests should pass prior to the changes mentioned.

The following should be tested (manually/automatically):

  1. receiving a message in an unread room causes it to transition to the "read" state;
  2. receiving a room state event for a room should update the respective view of the RoomTile, namely:
    • avatar;
    • name;
    • member event (in case the room name is "Alice, Bob and 2345 others";
  3. receiving a message in a room which is not at the top of a manually sorted RoomSubList;
  4. having a notification count > 0 should be displayed when we receive an event and the count is > 0;
  5. the notification count should be zeroed when we look at the room.

Automated test considerations:

1. and 2. could probably be done with a RoomTile instance and a mocked js-sdk (room/client). 3. would require RoomListStore only, with the assumption that the RLS state is accurately rendered.

@lukebarnard1
Copy link
Contributor Author

Some other ones I thought of:

  • receiving invites;
  • receiving group invites;
  • room tagging in general.

@lampholder lampholder added T-Task Tasks for the team like planning P1 labels Mar 27, 2018
@lukebarnard1 lukebarnard1 self-assigned this Apr 11, 2018
@turt2live
Copy link
Member

@lampholder what's the status of this one?

@lampholder
Copy link
Member

Hah, my manual qa results from a year ago can probably safely be closed :P Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 T-Task Tasks for the team like planning
Projects
None yet
Development

No branches or pull requests

3 participants