Fix typechecking #53
Merged
Fix typechecking #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 24, 2023 16:25
``` src/matrix_content_scanner/logutils.py:35: error: Unused "type: ignore" comment [unused-ignore] ``` The paragraph starting > This functionality can be used to inject your own values in https://docs.python.org/3/library/logging.html#logging.LogRecord seems to suggest our use is legitimate. Mypy things `record.request_id` is Any, according to reveal_type. Typeshed was changed to account for this in python/typeshed#7833
Annotations in iohttp got fixed in aio-libs/aiohttp#7077, and we're now pulling in a version with that fix.
python/mypy#2427 (comment) describes the mypy change, in mypy 1.1.0
This seems to be necessary after aio-libs/aiohttp@1c9aba9 Confusingly this reverted to the concrete type in aiohttp's `master` branch. Not sure what's going on there.
Missed in #39
DMRobertson
force-pushed
the
dmr/bump-mypy
branch
from
d087861 to
bc9ceba
Compare
erikjohnston
approved these changes
Nov 24, 2023
|
Thank youuuuu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52.
Commit messages have more details.
Drive-by fixes to remove twisted-related config, missed in #39.