Fix TransactionInactiveError on Safari #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this (almost) makes it work in some browsers that otherwise have throw a TransactionInactiveError on the first operation you try to do on a store.
...to the es5 one in gnome web. Alas, it does not, and I can't recreate the failure mode I see in the app when awaiting opening txns.
just in case
as errors will bubble up to the txn
Waiting for it to close magically solves the TransactionInactiveError we were seeing on some incremental sync request when reading from roomMembers. Still unsure what this is about, and if we should wait for all read txns to close or not.
in case we get a TransactionInactiveError, we have at least written the sync token and won't repeat the same sync request
bwindels
force-pushed
the
bwindels/idb-promises-txn
branch
from
97a70a0 to
b08b7e5
Compare
This was referenced Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
It also fixes an infinite loop in some cases when loading the app with pending messages in storage.
It also adds optional logging for idb requests for easier txn debugging.