Include KaTeX CSS as a dependency #15843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the KaTeX CSS inclusion to function just like the other bits of the CSS that we import from dependencies.
turt2live
approved these changes
Nov 30, 2020
| @@ -59,6 +59,7 @@ | |||
| "gfm.css": "^1.1.2", | |||
| "highlight.js": "^10.1.2", | |||
| "jsrsasign": "^9.1.5", | |||
| "katex": "^0.12.0", | |||
There was a problem hiding this comment.
won't this cause further issues with dependency version mismatch?
There was a problem hiding this comment.
It does mean it's a dependency in two layers, which adds some complexity, but it's also a much more correct expression of what we're actually doing. Also, without this PR, we're relying on a specific pattern layout of nested node_modules directories, which is undefined behaviour, and seemed to be breaking the RC build today, so I think that's enough evidence that we need this change.
There was a problem hiding this comment.
yea, understandable. Just concerned that we're going to forget to update the dependency in both layers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the KaTeX CSS inclusion to function just like the other bits of the
CSS that we import from dependencies.