Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the room list sorting #25032

Open
2 tasks done
daniellekirkwood opened this issue Apr 4, 2023 · 4 comments
Open
2 tasks done

Updates to the room list sorting #25032

daniellekirkwood opened this issue Apr 4, 2023 · 4 comments
Assignees
Labels
A-Room-List O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement Z-GetYourUpdates

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Apr 4, 2023

With the Notifications project and GYU we need to look at making some changes to the sorting on the room list.

The documentation outlining the goal is here.

Another piece of documentation that is relevant here is the intended default settings for new users: https://docs.google.com/document/d/1ryZjVuYBSfsu4e6fqYHIC9hJhY-aEWukcWMig1ewRA4/edit#heading=h.trije792g20r

TBD:

  • We might add a checkbox that allows users to toggle this mute behaviour - could we do that?)
  • Room cell decoration: We might change how the room list looks and the notifications that users receive visually...
@daniellekirkwood
Copy link
Contributor Author

@kerryarchibald Would you mind taking a look at the above things we've drafted and the room list in general and let me know your thoughts? Are the things we're asking for pretty straight-forward? Could we have a toggle in the overflow menu that let's users toggle the mute thing on and off (similar to the "show rooms with unreads")?

Image

@t3chguy I think this is related to the PR we were talking about earlier where the desired behaviour is to not have room events count as activity?

@daniellekirkwood
Copy link
Contributor Author

Things highlighted in the Signals and Notifications document (linked above) that we need to check are true (by default):

  • the room list does not update for message reactions
  • the room list does not update if messages were edited or deleted
  • the room list does update when new user or bot is invited to join a DM (but not for rooms)
  • the room list does not update when there are room events or name changes
  • the room list does not update when someone leaves

If any of these are false we either need to discuss them further or update the definition of done for this issue to correct them.

@andybalaam andybalaam added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Room-List T-Enhancement O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Apr 5, 2023
@daniellekirkwood
Copy link
Contributor Author

@kerryarchibald @justjanne the Element X team have decided a slightly different way of "putting muted rooms at the bottom" of the lists and its: 'Once the room is put on mute, don't move it up unless I post in that room'. Therefore the room moves down over time, unless the user actively posts in it.

Is that possible on Web, how much work would that be? Is it easier/harder/the same as forcing Muted rooms to the bottom of the list once they're on mute?

@kerryarchibald
Copy link
Contributor

kerryarchibald commented Apr 13, 2023

Things highlighted in the Signals and Notifications document (linked above) that we need to check are true (by default):

Screenshot 2023-04-13 at 15 30 57

cc @daniellekirkwood
  • the room list does not update for message reactions
  • the room list does not update if messages were edited or deleted
  • the room list does update when new user or bot is invited to join a DM
  • the room list does not update when new user or bot is invited to join a room
  • the room list does not update when there are room events or name changes
    • DM change room to public - no update
    • DM participant set room nick - no update
    • Group change room to public
    • Group add an admin
    • Group change room name
    • Group set participant room nick
  • the room list does not update when someone leaves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement Z-GetYourUpdates
Projects
None yet
Development

No branches or pull requests

3 participants