Nicer picture viewer opening animation

[HarHarLinks]

Is your suggestion related to a problem? Please describe.

Currently when clicking on a picture, it will darken the screen and then start a blowup animation (start as one pixel in the center and enlarge) of the picture to fit screen or 100% (citation needed) size. This might actually be more jarring than a quick fade-in.

Describe the solution you'd like.

Take the picture as it is shown when clicked, darken the background and transform it from there.
The Kodi mediacenter companion app kore does that animation when selecting an item to view details (i.e. a TV show or season).

Describe alternatives you've considered.

Use a less extreme animation, like said quick fade-in without transformation.

Additional context

accessibility perhaps?

what's the correct term for the "picture viewer"?

[ShadowJonathan]

FWIW discord does both, a fade-in while also blowing up from 50% size.

[SimonBrandner]

A quick PoC:

Peek.2021-07-22.21-05.mp4

[ShadowJonathan]

I don't like that, it's very slow, i'd recommend making it 0.2s or 0.5s

[SimonBrandner]

I don't like that, it's very slow, i'd recommend making it 0.2s or 0.5s

It was a PoC :P The PR should be a bit better though it's not ideal either

[HarHarLinks]

From the video, that matches what I wanted, except the animation speed. If the real speed matches that of the current, I think that would be satisfactory. Thanks!

[SimonBrandner]

Changing animation speed is the simple part :)

[SimonBrandner]

@HarHarLinks and @ShadowJonathan, could you please try out the live preview and share your thoughts?

[ShadowJonathan]

This looks good, although with the weird effect of the image not "scaling" from the current size to the new size looks weird;

zoom-2021-07-23_09.48.01.mp4

The new image with its full size just pops up on top of the timeline one, and that might be a bit jarring.

[SimonBrandner]

This looks good, although with the weird effect of the image not "scaling" from the current size to the new size looks weird;
zoom-2021-07-23_09.48.01.mp4

The new image with its full size just pops up on top of the timeline one, and that might be a bit jarring.

Hmm, looks like a bug :(

[HarHarLinks]

The first time clicking on an image with this, the transition does not work properly: noticeably the screen first darkens, only then the transformation happens. This is also on current nightly and presumably stable, probably due to the full size loading only when clicked on.
To solve this, I propose to use the thumbnail as a placeholder and replace it by the full size when that has (async) downloaded. Same could be applied to blurhash if not even the thumbnail has loaded (or if there isn't any).

Second and later times, it is much quicker (I believe as intended). It is quite nice, I like it.
I also like that you fade in the darkening effect of the background with the same transition time.

Please also add the reverse transition when closing the image viewer.

I am not sure what nor how to cause the bug ShadowJonathan showed.