Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization mechanism for authentication errors #7131

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Nov 30, 2022

The goal of this PR is to add localization for authentication errors.

After updating the authentication flow on Tchap, we noticed that the authentication errors were not translated anymore in other languages than English.

This PR add the translation mechanism used in Tchap.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 11.77% // Head: 11.76% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (83baeb5) compared to base (ef8a9be).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7131      +/-   ##
===========================================
- Coverage    11.77%   11.76%   -0.01%     
===========================================
  Files         1620     1621       +1     
  Lines       159318   159364      +46     
  Branches     64818    64851      +33     
===========================================
  Hits         18752    18752              
- Misses      139928   139974      +46     
  Partials       638      638              
Flag Coverage Δ
uitests 54.84% <ø> (+<0.01%) ⬆️
unittests 5.98% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Categories/MXError.swift 0.00% <0.00%> (ø)
...ator/AuthenticationChoosePasswordCoordinator.swift 0.00% <0.00%> (ø)
...ator/AuthenticationForgotPasswordCoordinator.swift 0.00% <0.00%> (ø)
...n/Coordinator/AuthenticationLoginCoordinator.swift 3.84% <0.00%> (-0.02%) ⬇️
...ordinator/AuthenticationReCaptchaCoordinator.swift 0.00% <0.00%> (ø)
...inator/AuthenticationRegistrationCoordinator.swift 3.84% <0.00%> (-0.02%) ⬇️
...rdinator/AuthenticationSoftLogoutCoordinator.swift 6.52% <0.00%> (-0.05%) ⬇️
...s/Coordinator/AuthenticationTermsCoordinator.swift 0.00% <0.00%> (ø)
...dinator/AuthenticationVerifyEmailCoordinator.swift 0.00% <0.00%> (ø)
...inator/AuthenticationVerifyMsisdnCoordinator.swift 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phloux phloux marked this pull request as ready for review December 2, 2022 16:51
@phloux phloux requested review from a team and aringenbach and removed request for a team December 2, 2022 16:51
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phloux phloux merged commit 0a7ed27 into develop Dec 5, 2022
@phloux phloux deleted the phlpro/localize_authentication_errors branch December 5, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants