Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 10s wait on failed initial sync #7068

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Remove 10s wait on failed initial sync #7068

merged 1 commit into from
Nov 14, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Nov 10, 2022

There is no reason to arbitrarily delay another sync, and waiting too long could lead to server clearing any cache it has.

@Anderas Anderas requested review from a team and phloux and removed request for a team November 10, 2022 16:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 11.72% // Head: 11.81% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (f97903b) compared to base (2184f1f).
Patch coverage: 28.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7068      +/-   ##
===========================================
+ Coverage    11.72%   11.81%   +0.08%     
===========================================
  Files         1613     1620       +7     
  Lines       158529   158709     +180     
  Branches     64369    64540     +171     
===========================================
+ Hits         18589    18745     +156     
- Misses      139305   139326      +21     
- Partials       635      638       +3     
Flag Coverage Δ
uitests 54.38% <47.03%> (-0.10%) ⬇️
unittests 6.07% <5.20%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Config/BuildSettings.swift 43.07% <ø> (ø)
Riot/Categories/MXKRoomBubbleTableViewCell+Riot.m 0.00% <0.00%> (ø)
Riot/Managers/Settings/RiotSettings.swift 88.33% <ø> (-0.10%) ⬇️
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 12.92% <0.00%> (-0.21%) ⬇️
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% <0.00%> (ø)
Riot/Modules/TabBar/MasterTabBarController.m 0.00% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Extensions/View.swift 0.00% <0.00%> (ø)
...n/InfoSheet/Coordinator/InfoSheetCoordinator.swift 0.00% <0.00%> (ø)
.../Modules/Common/InfoSheet/InfoSheetViewModel.swift 0.00% <0.00%> (ø)
... and 48 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anderas Anderas merged commit 68ce83e into develop Nov 14, 2022
@Anderas Anderas deleted the andy/repeat_sync branch November 14, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants