Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/Hide IP in device manager (PSG-804) #7028

Merged
merged 19 commits into from
Nov 3, 2022

Conversation

alfogrillo
Copy link
Contributor

Description

This PR add the possibility to show/hide the ip addresses in:

  • Sessions overview
  • All the sessions
  • Single session overview

The setting is persisted

Simulator Screen Recording - iPhone 14 Pro - 2022-11-02 at 20 19 36

@alfogrillo alfogrillo requested review from a team and gileluard and removed request for a team November 2, 2022 19:29
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 11.76% // Head: 11.78% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (4a98acd) compared to base (848a6db).
Patch coverage: 63.92% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7028      +/-   ##
===========================================
+ Coverage    11.76%   11.78%   +0.02%     
===========================================
  Files         1608     1611       +3     
  Lines       158029   158118      +89     
  Branches     64059    64239     +180     
===========================================
+ Hits         18588    18631      +43     
- Misses      138814   138858      +44     
- Partials       627      629       +2     
Flag Coverage Δ
uitests 54.62% <68.75%> (+0.02%) ⬆️
unittests 6.08% <1.26%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Modules/Common/ViewModel/StateStoreViewModel.swift 82.60% <ø> (ø)
...DK/RiotSettings+ UserSessionSettingsProtocol.swift 0.00% <0.00%> (ø)
...UserSessions/Common/View/UserSessionCardView.swift 53.23% <0.00%> (-5.41%) ⬇️
...ons/Coordinator/UserOtherSessionsCoordinator.swift 0.00% <0.00%> (ø)
...w/Coordinator/UserSessionOverviewCoordinator.swift 0.00% <0.00%> (ø)
.../Coordinator/UserSessionsOverviewCoordinator.swift 0.00% <0.00%> (ø)
...rSessionsOverview/UserSessionsOverviewModels.swift 100.00% <ø> (ø)
...onsOverview/View/UserSessionListItemViewData.swift 100.00% <ø> (ø)
...SessionOverview/UserSessionOverviewViewModel.swift 61.53% <50.00%> (-1.80%) ⬇️
...serSessionsOverview/View/UserSessionListItem.swift 63.85% <52.63%> (-4.72%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo changed the title Show/Hide IP in device manager Show/Hide IP in device manager (PSG-804) Nov 3, 2022
@alfogrillo alfogrillo force-pushed the alfogrillo/show_ip_feature branch from 668fdac to 0ad8217 Compare November 3, 2022 08:15
@alfogrillo alfogrillo force-pushed the alfogrillo/show_ip_feature branch from 0ad8217 to 4a98acd Compare November 3, 2022 13:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alfogrillo alfogrillo merged commit 8f23b46 into develop Nov 3, 2022
@alfogrillo alfogrillo deleted the alfogrillo/show_ip_feature branch November 3, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants