Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Green Spinner is dismissed too soon. Can cause incorrect ordering/display of onboarding screens. #5472

Closed
langleyd opened this issue Feb 1, 2022 · 1 comment · Fixed by #5476
Closed

Green Spinner is dismissed too soon. Can cause incorrect ordering/display of onboarding screens. #5472

langleyd opened this issue Feb 1, 2022 · 1 comment · Fixed by #5476
Assignees
@langleyd
Labels
A-Startup S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@langleyd
Copy link
Member

langleyd commented Feb 1, 2022

The green spinner is sometimes dismissed too soon causing downstream apps to sometimes show the 4s backup setup screen to be displayed when it should not.
@langleyd langleyd self-assigned this Feb 1, 2022
@pixlwave
Copy link
Member

pixlwave commented Feb 1, 2022 •
edited
Loading

Is this since #5398 was merged or before? Might be related to the 2 warnings here:
https://github.com/vector-im/element-ios/blob/4da3bbf6a3e32a53f036cc7a4f0be94ab3f37de8/Riot/Modules/TabBar/MasterTabBarController.m#L534

Edit: Just seen the PR, clearly unrelated. The mystery continues!

@langleyd langleyd mentioned this issue Feb 1, 2022
Merged
@stefanceriu stefanceriu added A-Startup S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@langleyd langleyd

Labels
A-Startup S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Green spinner hidden too early element-hq/element-ios
3 participants
@stefanceriu @pixlwave @langleyd