Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

empty DMs are misnamed #4717

Closed
ara4n opened this issue Aug 16, 2021 · 1 comment
Closed

empty DMs are misnamed #4717

ara4n opened this issue Aug 16, 2021 · 1 comment
Assignees
@stefanceriu

Comments

@ara4n
Copy link
Member

ara4n commented Aug 16, 2021

should be 'Empty (was Matthew)' or similar, but instead it shows the raw mxid of the person who parted
@stefanceriu
Copy link
Member

  • As a user who has a DM conversation with a user that leaves the room
  • I see the room labelled as [User Name] (Left)
  • So that I know who the conversation was with, but also that they are no longer in the room

This makes it clear who the conversation was with, and prevents the scenario of having a lot of rooms named 'Empty room' grouped together when DMs are sorted alphabetically. However it should still make it clear that the room is now empty.

@stefanceriu stefanceriu self-assigned this Sep 23, 2021
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Sep 23, 2021
@stefanceriu
Fixes element-hq/element-ios/issues/4717 - Renaming DM rooms to [User…
c07bb58 
… Name](Left) after the only other participant leaves.
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Sep 23, 2021
@stefanceriu
element-hq/element-ios/issues/4717 - Exposed new room name localizabl…
a55541a 
…e string to use for empty direct messages.
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Sep 23, 2021
@stefanceriu
element-hq/element-ios/issues/4717 - Exposed new room name localizabl…
35b1b3c 
…e string to use for empty direct messages.
stefanceriu added a commit to matrix-org/matrix-ios-sdk that referenced this issue Sep 23, 2021
@stefanceriu
Fixes element-hq/element-ios/issues/4717 - Renaming DM rooms to [User…
51595c4 
… Name](Left) after the only other participant leaves.
stefanceriu added a commit to matrix-org/matrix-ios-kit that referenced this issue Sep 27, 2021
@stefanceriu
element-hq/element-ios/issues/4717 - Exposed new room name localizabl…
9a92467 
…e string to use for empty direct messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanceriu stefanceriu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanceriu @ara4n