Add client base url support for permalinks #4027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florian14
force-pushed
the
feature/fre/permalink
branch
3 times, most recently
from
3968131 to
1d5ece7
Compare
bmarty
requested changes
Sep 17, 2021
...ix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/permalinks/MatrixToMapper.kt
Outdated
Show resolved
Hide resolved
...ix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/permalinks/MatrixToMapper.kt
Outdated
Show resolved
Hide resolved
...x-sdk-android/src/main/java/org/matrix/android/sdk/api/session/permalinks/PermalinkParser.kt
Show resolved
Hide resolved
...-sdk-android/src/main/java/org/matrix/android/sdk/api/session/permalinks/PermalinkService.kt
Outdated
Show resolved
Hide resolved
...-sdk-android/src/main/java/org/matrix/android/sdk/api/session/permalinks/PermalinkService.kt
Show resolved
Hide resolved
bmarty
reviewed
Sep 17, 2021
...ix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/permalinks/MatrixToMapper.kt
Outdated
Show resolved
Hide resolved
bmarty
reviewed
Sep 17, 2021
...ix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/permalinks/MatrixToMapper.kt
Outdated
Show resolved
Hide resolved
Florian14
force-pushed
the
feature/fre/permalink
branch
from
1d5ece7 to
054fc96
Compare
ganfra
approved these changes
Sep 17, 2021
...-sdk-android/src/main/java/org/matrix/android/sdk/api/session/permalinks/PermalinkService.kt
Show resolved
Hide resolved
Also convert links to matrix.to before permalink parsing
Florian14
force-pushed
the
feature/fre/permalink
branch
from
054fc96 to
86dc340
Compare
giomfo
reviewed
Sep 17, 2021
...x-sdk-android/src/main/java/org/matrix/android/sdk/api/session/permalinks/PermalinkParser.kt
Outdated
Show resolved
Hide resolved
giomfo
reviewed
Sep 17, 2021
matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/MatrixConfiguration.kt
Outdated
Show resolved
Hide resolved
giomfo
reviewed
Sep 17, 2021
giomfo
reviewed
Sep 17, 2021
vector/src/main/java/im/vector/app/features/permalink/PermalinkHandler.kt
Show resolved
Hide resolved
Florian14
force-pushed
the
feature/fre/permalink
branch
from
86dc340 to
3c82187
Compare
Florian14
force-pushed
the
feature/fre/permalink
branch
from
3c82187 to
fa3abec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a field
clientPermalinkBaseUrlinto theMatrixConfigurationobject.If not null, this base url will be used to generate custom permalinks instead of usual
matrix.tolinks.eg. "https://www.example.org/#" for "https://www.example.org/#/room/#element-android:matrix.org"