Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buildjet-4vcpu-ubuntu-2204 runner instead of macos-latest to … #7108

Merged
merged 11 commits into from
Sep 20, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 13, 2022

…build and run the integration tests.

Draft, to see how the CI will digest this change.

post build result (using 4vcpu runner):

Before After
(from #7015) 74 minutes image 23 minutesimage

Just for this specific job. I will also remove the second attempt as discussed today, since it looks not very useful.

EDIT
PR content is:

  • Use buildjet-4vcpu-ubuntu-2204 for integration test and post-pr jobs
  • Remove second attempt to run integration tests
  • Upload artifacts with the test result: Html report and logcat output are included in the artifacts
  • Try to use a cached emulator (not sure that this is working according to the log of the action)

TODO in a separate PR:

  • Fix failing tests
  • stop trying to export code coverage to sonar if there are failing test. This is maybe the root cause of the 0% coverage reported by sonar

TODO in a separate PR:

  • test the other available buildjet runners, to compare performance, and see if it worth paying more.

@bmarty bmarty force-pushed the feature/bma/trybuildjet branch from 96c9883 to 1afe098 Compare September 16, 2022 15:24
@bmarty bmarty marked this pull request as ready for review September 16, 2022 17:01
@bmarty bmarty requested review from a team and jmartinesp and removed request for a team September 16, 2022 17:01
@@ -31,7 +31,7 @@ jobs:
ui-tests:
name: UI Tests (Synapse)
needs: should-i-run
runs-on: macos-latest
runs-on: buildjet-4vcpu-ubuntu-2204
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We start with this runner and will compare later the perf of other available (but more not with the same price) runners.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try first with buildjet-2vcpu-ubuntu-2204?
And use beefier machines only if we can prove there are better?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 0685fb1

@bmarty bmarty changed the title Use buildjet-4vcpu-ubuntu-2204 runner instead of macos-latest to … Use buildjet-2vcpu-ubuntu-2204 runner instead of macos-latest to … Sep 19, 2022
@bmarty
Copy link
Member Author

bmarty commented Sep 19, 2022

It seems that with buildjet-2vcpu-ubuntu-2204 we do not have enough RAM. See https://github.com/vector-im/element-android/actions/runs/3080897698/jobs/4980174874 failure.

Can we revert to 4vcpu which got 16 GB of RAM (2x the RAM available on 4vcpu) @manuroe ?

@manuroe
Copy link
Member

manuroe commented Sep 19, 2022

Ok. Thanks for having tried.

Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the PR title again. Then, it is all good to me 🚀🚀🚀

changelog.d/7108.misc Outdated Show resolved Hide resolved
@fedrunov
Copy link
Contributor

fedrunov commented Sep 19, 2022

It shows "all checks haves passed", while all-tests has actually failed. Probably because of continue-on-error: true. community/community#15452

It does not mark the build as failed.
@bmarty bmarty changed the title Use buildjet-2vcpu-ubuntu-2204 runner instead of macos-latest to … Use buildjet-4vcpu-ubuntu-2204 runner instead of macos-latest to … Sep 19, 2022
@bmarty bmarty force-pushed the feature/bma/trybuildjet branch from 302ed79 to aa010de Compare September 20, 2022 07:51
@bmarty bmarty merged commit b7c6390 into develop Sep 20, 2022
@bmarty bmarty deleted the feature/bma/trybuildjet branch September 20, 2022 07:51
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants