-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use buildjet-4vcpu-ubuntu-2204
runner instead of macos-latest
to …
#7108
Conversation
…build and run the integration tests.
…build and run the integration tests for the post merge task.
96c9883
to
1afe098
Compare
@@ -31,7 +31,7 @@ jobs: | |||
ui-tests: | |||
name: UI Tests (Synapse) | |||
needs: should-i-run | |||
runs-on: macos-latest | |||
runs-on: buildjet-4vcpu-ubuntu-2204 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We start with this runner and will compare later the perf of other available (but more not with the same price) runners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we try first with buildjet-2vcpu-ubuntu-2204
?
And use beefier machines only if we can prove there are better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. 0685fb1
buildjet-4vcpu-ubuntu-2204
runner instead of macos-latest
to …buildjet-2vcpu-ubuntu-2204
runner instead of macos-latest
to …
It seems that with Can we revert to |
Ok. Thanks for having tried. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to change the PR title again. Then, it is all good to me 🚀🚀🚀
It shows "all checks haves passed", while |
It does not mark the build as failed.
buildjet-2vcpu-ubuntu-2204
runner instead of macos-latest
to …buildjet-4vcpu-ubuntu-2204
runner instead of macos-latest
to …
302ed79
to
aa010de
Compare
Co-authored-by: manuroe <[email protected]>
SonarCloud Quality Gate failed. |
…build and run the integration tests.
Draft, to see how the CI will digest this change.
post build result (using
4vcpu
runner):Just for this specific job. I will also remove the second attempt as discussed today, since it looks not very useful.
EDIT
PR content is:
buildjet-4vcpu-ubuntu-2204
for integration test and post-pr jobsTODO in a separate PR:
TODO in a separate PR: