Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bma/http log #6925

Merged
merged 4 commits into from
Aug 29, 2022
Merged

Feature/bma/http log #6925

merged 4 commits into from
Aug 29, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 24, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Ensure HTTP logger are working in production, for basic logs.

Motivation and context

Fixes #6923
Have more info about HTTP traffic in the rageshake.

Screenshots / GIFs

Log with configuration HttpLoggingInterceptor.Level.BASIC (used in production):

2022-08-24 12:35:38.886 6480-14447/im.vector.app.debug V/FormattedJsonHttpLogger: --> POST https://matrix-client.matrix.org/_matrix/client/r0/login (155-byte body)
2022-08-24 12:35:39.524 6480-14447/im.vector.app.debug V/FormattedJsonHttpLogger: <-- 200 OK https://matrix-client.matrix.org/_matrix/client/r0/login (637ms, unknown-length body)

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested review from a team and onurays and removed request for a team August 24, 2022 10:37
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

15.2% 15.2% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. LGTM!

@bmarty bmarty merged commit 51dcaf7 into develop Aug 29, 2022
@bmarty bmarty deleted the feature/bma/http_log branch August 29, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production rageshake does not contain HTTP request
2 participants