New App Layout: Adds New Chat Bottom Sheet #6801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedrunov
suggested changes
Aug 16, 2022
| android:paddingHorizontal="16dp" | ||
| android:paddingVertical="16dp" | ||
| android:text="@string/start_chat" | ||
| android:textAppearance="@style/TextAppearance.Vector.Body" |
There was a problem hiding this comment.
you apply both style and textAppearance`. We should only apply style which fits by text size and override other params if necessary
| android:paddingHorizontal="16dp" | ||
| android:paddingVertical="16dp" | ||
| android:text="@string/create_room" | ||
| android:textAppearance="@style/TextAppearance.Vector.Body" |
| } | ||
|
|
||
| binding.createRoom.setOnClickListener { | ||
| navigator.openCreateRoom(requireActivity(), "") |
There was a problem hiding this comment.
initialName param of openCreateRoom has default value, so you can just skip it
…hat-bottom-sheet # Conflicts: # vector/src/main/res/values/strings.xml
|
SonarCloud Quality Gate failed. |
onurays
reviewed
Aug 19, 2022
| @@ -166,7 +168,7 @@ class HomeRoomListFragment @Inject constructor( | |||
| showFABs() | |||
|
|
|||
| views.newLayoutCreateChatButton.setOnClickListener { | |||
| // Click action for create chat modal goes here (Issue #6717) | |||
| newChatBottomSheet.show(requireActivity().supportFragmentManager, NewChatBottomSheet.TAG) | |||
There was a problem hiding this comment.
Nit: Wdyt about creating the bottom sheet instance here instead of a class variable?
There was a problem hiding this comment.
I wouldn't prefer doing it this way because we're creating new instances of the bottom sheet every time and adding it to memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Motivation and context
Closes #6717
This is the new way we differentiate between a new DM or a new create room chat when using the FAB on the main screen
Screenshots / GIFs
Tests
Tested devices
Checklist