Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New App Layout: Space name reflected in toolbar #6795

Merged
merged 2 commits into from
Aug 17, 2022
Merged

New App Layout: Space name reflected in toolbar #6795

merged 2 commits into from
Aug 17, 2022

Conversation

ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Aug 10, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Changes the space name shown in the toolbar as the space is switched

Closes #6752

Screenshots / GIFs

Tests

  • Make sure New App Layout feature flag is enabled
  • Switch spaces and see that the space title in the toolbar is also updated

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 12

Checklist

@ericdecanini ericdecanini added the PR-Small PR with less than 20 updated lines label Aug 10, 2022
@ericdecanini ericdecanini requested review from fedrunov and a team August 10, 2022 06:30
@ericdecanini ericdecanini changed the base branch from develop to feature/eric/space-list-modal August 10, 2022 06:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

yostyle
yostyle approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fedrunov
fedrunov approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feature/eric/space-list-modal to develop August 17, 2022 08:51
@ericdecanini ericdecanini merged commit b6bcefb into develop Aug 17, 2022
@ericdecanini ericdecanini deleted the feature/eric/toolbar-space-name branch August 17, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedrunov fedrunov fedrunov approved these changes

@yostyle yostyle yostyle approved these changes

Assignees
No one assigned
Labels
PR-Small PR with less than 20 updated lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Space Switching: Update Toolbar with Current Space
3 participants
@ericdecanini @yostyle @fedrunov