Put EC permission shortcuts behind labs flag (PSG-630) #6634

Johennes · 2022-07-25T08:02:01Z

Signed-off-by: Johannes Marbach [email protected]

Type of change

Feature
Bugfix
Technical
Other :

Content

This is a follow-up on #6616 that puts the Element Call permission shortcuts behind a labs flag. Anyone can create a false widget of type io.element.call and silently acquire permissions so we don't want to enable this behavior by default.

Tests

Can be tested e.g. in #ecwidgettest:matrix.org

Tested devices

Physical
Emulator
OS version(s): 12

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

CC @onurays

Signed-off-by: Johannes Marbach <[email protected]>

Johennes · 2022-07-25T08:13:22Z

vector/src/main/java/im/vector/app/features/widgets/WidgetActivity.kt

@@ -168,7 +173,7 @@ class WidgetActivity : VectorBaseActivity<ActivityWidgetBinding>() {
    private fun createElementCallPipParams(): PictureInPictureParams? {
        val actions = mutableListOf<RemoteAction>()
        val intent = Intent(ACTION_MEDIA_CONTROL).putExtra(EXTRA_CONTROL_TYPE, CONTROL_TYPE_HANGUP)
-        val pendingIntent = PendingIntent.getBroadcast(this, REQUEST_CODE_HANGUP, intent, 0)
+        val pendingIntent = PendingIntent.getBroadcast(this, REQUEST_CODE_HANGUP, intent, FLAG_IMMUTABLE)
