Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Location Sharing - Reset zoom level while focusing a user (PSG-624) #6609

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

onurays
Copy link
Contributor

@onurays onurays commented Jul 20, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

When a user is selected on bottom sheet of maximized live location map view, we shouldn't preserve the current zoom level. Changing zoom level to a meaningful value will improve UX.

Motivation and context

Screenshots / GIFs

WhatsApp.Video.2022-07-20.at.15.56.09.mp4

Tests

  • Share a live location
  • Tap on the live location message in the timeline
  • On maximized map screen tap on user to focus

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@onurays onurays requested review from a team and Claire1817 and removed request for a team July 20, 2022 13:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@Claire1817 Claire1817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple question.

@onurays onurays requested a review from Claire1817 July 21, 2022 23:10
@onurays onurays merged commit 6a9b496 into develop Jul 22, 2022
@onurays onurays deleted the feature/ons/reset_zoom_level_on_user_focus branch July 22, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants