Simple check to prevent frozen class modification #6434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmarty Adding you as reviewer, not sure if it's the best place/way to do that. |
|
Kudos, SonarCloud Quality Gate passed!
|
bmarty
approved these changes
Jul 1, 2022
bmarty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Quick technical change to add a check to prevent the modification of some serializable classes.
Historically megolm session where serialized using java serialization mechanism but without proper version. Any change to those class will make it impossible for the app to load saved session.
This change adds a check to fail when such frozen class is modified.