Fix StackOverflowError while recording voice message [PSF-1065]

[onurays]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

• Start recording a voice message and lock the mic.
• Wait for 2 minutes (max length of a voice message)
• The app crashes

Motivation and context

Fixes #6137

Screenshots / GIFs

Tests

• Start recording a voice message and wait for 2 minutes
• Send the record, delete the record and everything should work as expected

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[github-actions]

Unit Test Results

146 files  ±0  146 suites  ±0   2m 9s ⏱️ -36s
236 tests ±0  236 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
788 runs  ±0  788 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0b9db0e. ± Comparison against base commit 033b877.

♻️ This comment has been updated with latest results.

[bmarty]

I understand that we want to keep the last maxVisibleBarCount items on the list.

Can it be rewritten like this:

if (visibleBarHeights.size > maxVisibleBarCount) {
        visibleBarHeights = visibleBarHeights.takeLast(maxVisibleBarCount).toMutableList()
        // Or, but maybe less clear
        visibleBarHeights = visibleBarHeights.drop(maxVisibleBarCount - visibleBarHeights.size).toMutableList()
}

Alternatively we could drop the first items like this:

            while (visibleBarHeights.size > maxVisibleBarCount) {
                visibleBarHeights.removeAt(0)
            }

which has the advantage of not creating a new list. Also it should in fact only drop one item, each time we add an item and make the list too long.

To me those both suggestions are easier to read.

[onurays]

Good ideas, thanks!

[github-actions]

Matrix SDK

Integration Tests Results:

• [org.matrix.android.sdk.session]
  = passed=19 failures=1 errors=0 skipped=3
• [org.matrix.android.sdk.account]
  = passed=3 failures=0 errors=0 skipped=2
• [org.matrix.android.sdk.internal]
  = passed=27 failures=1 errors=0 skipped=1
• [org.matrix.android.sdk.ordering]
  = passed=16 failures=0 errors=0 skipped=0
• [org.matrix.android.sdk.PermalinkParserTest]
  = passed=2 failures=0 errors=0 skipped=0