Fixed grammar in 2 English strings #6132
Conversation
`room_list_people_empty_body` and `room_list_rooms_empty_body`
| <string name="room_list_rooms_empty_title">Rooms</string> | ||
| <string name="room_list_rooms_empty_body">Your rooms will be displayed here. Tap the + bottom right to find existing ones or start some of your own.</string> | ||
| <string name="room_list_rooms_empty_body">Your rooms will be displayed here. Tap the + at the bottom right to find existing ones or start some of your own.</string> |
There was a problem hiding this comment.
Note to myself: add a comment above this 2 strings to let translators knows that on RTL languages the button will be at bottom left.
There are some mistake currently about that:
Since this string will be updated, the translators will have the opportunity to fix that.
There was a problem hiding this comment.
this copy has been added to the FTUE copy review document, potentially we could avoid specifying the exact location of the fab (or even the fab at all 🤔 )
|
The original screen for context
|
|
for context, we're about to start a copy review of the new onboarding process and this suggestion has highlighted that the current empty screen copy could be further improved, we'll add it to the review process I'm happy to include this change but it may change again~! |
Type of change
Content
Fixed 2 strings in English;
room_list_people_empty_bodyandroom_list_rooms_empty_bodyin /vector/src/main/res/values/strings.xmlMotivation and context
I'm submitting this PR because of the other PR I made in SchildiChat/SchildiChat-android: SchildiChat#125
Testing
Testing isn't necessary
Checklist
Signed-off-by: Jeremy Baxter [email protected]