Native lookup fixes

[chagai95]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

refactor - better naming, return native user id and not sip user id and create a dm with the native user instead of with the sip user

Motivation and context

When dialing an extension which has a native user behind it, a native matrix call happens instead of a matrix sip call because the user id of the sip user was used instead of the native one - so the sip virtual lookup (which comes in this case after the native lookup) failed. Otherwise also creating a native room when one does not exist seems like the right thing to do and the code looks more clear with these names.

Screenshots / GIFs

Tests

• private setup - you should have access in Aarenet/Element room

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

Signed-off-by: Chagai Friedlander @me:chagai.website

[bmarty]

Thanks, for the PR.
LGTM, but I will defer to @ganfra and/or @dbkr for the logic.

[bmarty]

(can you check the compilation issues please?)

[chagai95]

(can you check the compilation issues please?)

Couldn't figure out where the actual errors are... can you help me with that?

[bmarty]

You are maybe not using the latest develop from mainline?
The code should be session .roomService() .getExistingDirectRoomWithUser(nativeUserId) now

[chagai95]

oops, completely missed that - copy pasted that part of the change from our fork, sorry.

[bmarty]

An import of Timber is missing.

[chagai95]

Yep, sorry 🙈

[bmarty]

(can you check the compilation issues please?)

Couldn't figure out where the actual errors are... can you help me with that?

I have added some comments and the error details can be found on clicking on "Details" (in case you are not aware of that):

[bmarty]

(it's confirmed I am not the only one to create PR without even having compiled the code locally!)

[chagai95]

(can you check the compilation issues please?)

Couldn't figure out where the actual errors are... can you help me with that?

I have added some comments and the error details can be found on clicking on "Details" (in case you are not aware of that):

I tried that, but still couldn't really figure out where the errors are... sorry... also sorry for not compiling locally 🙈
Here is a screen cap of me trying to understand the failing builds:
https://aarenet-my.sharepoint.com/:v:/p/chagai_friedlander/EcN-uVEqkIxGkfvg3lPYKVQBGVsf0T_6BMwpUkVH7VGilA

[dbkr]

The (pre-existing) variable names in here are quite confusing, but the logic of the change looks correct.

[chagai95]

I think everything passed?

* What went wrong:
Execution failed for task ':sonarqube'.
> Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator

[bmarty]

The error reported by the CI can be ignored; we will try to fix that.
Thanks for the update, and thanks @dbkr for the review!