F-Droid can't build - org.maplibre.gl:android-sdk pulls in non-FOSS Google Services #6100

licaon-kter · 2022-05-19T10:19:02Z

Steps to reproduce

Try to build for fdroid... gradle dependencies for fdroidRelease* says:

+--- org.maplibre.gl:android-sdk:9.5.2
|    +--- org.maplibre.gl:android-sdk-geojson:5.9.0
|    |    \--- com.google.code.gson:gson:2.8.6
|    +--- com.mapbox.mapboxsdk:mapbox-android-gestures:0.7.0
|    |    +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
|    |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
|    +--- org.maplibre.gl:android-sdk-turf:5.9.0
|    |    \--- org.maplibre.gl:android-sdk-geojson:5.9.0 (*)
|    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
|    +--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
|    +--- com.squareup.okhttp3:okhttp:3.12.3 -> 4.9.3 (*)
|    \--- com.google.android.gms:play-services-location:16.0.0

Since: 824e713

Outcome

Can't build from FOSS deps

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

The text was updated successfully, but these errors were encountered:

licaon-kter · 2022-05-19T10:51:10Z

Element 1.13.18 or later (first one published by F-Droid since it skipped 1.13.16/17)

And @SpiritCroc Schildi Chat 1.4.4.sc50 or later

licaon-kter · 2022-05-20T07:55:09Z

Will rebuild with this fix deltachat/deltachat-android#2303 to test now

bmarty · 2022-05-20T07:57:10Z

Thanks for opening the issue.

We could try the same fix than deltachat/deltachat-android#2303

Also we could add a check of issue like that to our CI. F-Droid team is working on a standalone version of the F-Droid scanner. So this will be for later.

Also the plan is to skip release 1.4.16 on F-Droid, fix this issue and release next 1.4.18 on F-Droid. At the end the previous "non-strictly-free" versions of Element Android on F-Droid will be disabled. This are versions from 1.3.16 to 1.4.14.

Labelled as S-Critical as it's preventing F-Droid version from being released.

ouchadam · 2022-05-20T08:03:05Z

if the dependency exclusion doesn't work we may need to exclude the feature from the fdroid variant

bmarty · 2022-05-20T08:05:43Z

if the dependency exclusion doesn't work we may need to exclude the feature from the fdroid variant

It will have to be checked, but according to the description of deltachat/deltachat-android#2303 it should work fine 🤞

licaon-kter · 2022-05-20T11:18:27Z

While DeltaChat builds fine and clean it's not the same here. gms classes are still inside the APK.

I've edited from implementation 'org.maplibre.gl:android-sdk:9.5.2' to implementation ('org.maplibre.gl:android-sdk:9.5.2') { exclude group: 'com.google.android.gms' }

Retrying now with the same version 9.4.0, maybe it matters

licaon-kter · 2022-05-20T11:44:14Z

Fails in a different way:

> Task :library:ui-styles:compileReleaseJavaWithJavac

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':vector:dataBindingMergeDependencyArtifactsFdroidRelease'.
> Could not resolve all files for configuration ':vector:fdroidReleaseCompileClasspath'.
   > Could not find com.mapbox.mapboxsdk:mapbox-android-accounts:0.7.0.
     Required by:
         project :vector > org.maplibre.gl:android-sdk:9.4.2

Of note I did specify 9.4.0 not 9.4.2 but maybe it's the way it works and uses latest point release?

/LE: deps

+--- org.maplibre.gl:android-sdk:9.4.0 -> 9.4.2
|    +--- org.maplibre.gl:android-sdk-geojson:5.9.0
|    |    \--- com.google.code.gson:gson:2.8.6
|    +--- com.mapbox.mapboxsdk:mapbox-android-gestures:0.7.0
|    |    +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
|    |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
|    +--- com.mapbox.mapboxsdk:mapbox-android-accounts:0.7.0 FAILED
|    +--- org.maplibre.gl:android-sdk-turf:5.9.0
|    |    \--- org.maplibre.gl:android-sdk-geojson:5.9.0 (*)
|    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
|    +--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
|    +--- com.squareup.okhttp3:okhttp:3.12.3 -> 4.9.3 (*)
|    \--- com.google.android.gms:play-services-location:16.0.0
|         +--- com.google.android.gms:play-services-base:16.0.1
|         |    +--- com.google.android.gms:play-services-basement:16.0.1
|         |    |    \--- com.android.support:support-v4:26.1.0 -> androidx.legacy:legacy-support-v4:1.0.0 (*)
|         |    \--- com.google.android.gms:play-services-tasks:16.0.1
|         |         \--- com.google.android.gms:play-services-basement:16.0.1 (*)
|         +--- com.google.android.gms:play-services-basement:16.0.1 (*)
|         +--- com.google.android.gms:play-services-places-placereport:16.0.0
|         |    \--- com.google.android.gms:play-services-basement:16.0.1 (*)
|         \--- com.google.android.gms:play-services-tasks:16.0.1 (*)

licaon-kter · 2022-05-20T13:16:51Z

For comparison, deps tree for DeltaChat with 9.4.0 and excluded gms:

\--- org.maplibre.gl:android-sdk:9.4.0
     +--- com.mapbox.mapboxsdk:mapbox-sdk-geojson:5.3.0
     |    \--- com.google.code.gson:gson:2.8.6
     +--- com.mapbox.mapboxsdk:mapbox-android-gestures:0.7.0
     |    +--- androidx.core:core:1.0.0 -> 1.3.2 (*)
     |    \--- androidx.annotation:annotation:1.0.0 -> 1.1.0
     +--- com.mapbox.mapboxsdk:mapbox-android-accounts:0.7.0
     |    \--- androidx.annotation:annotation:1.0.0 -> 1.1.0
     +--- com.mapbox.mapboxsdk:mapbox-sdk-turf:5.3.0
     |    \--- com.mapbox.mapboxsdk:mapbox-sdk-geojson:5.3.0 (*)
     +--- androidx.annotation:annotation:1.0.0 -> 1.1.0
     +--- androidx.fragment:fragment:1.0.0 -> 1.2.4 (*)
     \--- com.squareup.okhttp3:okhttp:3.12.3
          \--- com.squareup.okio:okio:1.15.0

bmarty · 2022-05-20T15:30:00Z

It should work fine, I will give it a try.

It's already done here: https://github.com/vector-im/element-android/blob/main/vector/build.gradle#L489 FWIW.

OOI what is the meaning of /LE ?

licaon-kter · 2022-05-20T16:52:34Z

Later Edit but what does OOI mean? :)

Not sure why you've linked to JitsiMeet... this issue is about gms brought by maplibre...as all my posts above show

😕

bmarty · 2022-05-20T17:18:13Z

Out Of Interest :)

I wanted to point out that we are already excluding the group for another of our dependency: exclude group: 'com.google.android.gms'. So it should work the same for MapLibre.

licaon-kter · 2022-05-25T09:26:06Z

Confirmed fixed in: ae9922a

VT: https://www.virustotal.com/gui/file/1df50475eae518671fd947245f3607e09c1ad38c1e467f0d9d5bb413bb5bfc30/details

ouchadam · 2022-05-25T09:27:19Z

@licaon-kter thanks for confirming! 💯

Scheduled to be released in 1.4.18

licaon-kter · 2022-05-25T09:41:04Z

Disabled old ones: https://gitlab.com/fdroid/fdroiddata/-/commit/2113d686eb3ee4525ef141a39e095ea4e37e2653

@SpiritCroc fyi https://gitlab.com/fdroid/fdroiddata/-/commit/0507813723a4551d2eb0428b4454d7bc04e75ecc

SpiritCroc · 2022-05-25T09:46:22Z

Disabled old ones: https://gitlab.com/fdroid/fdroiddata/-/commit/2113d686eb3ee4525ef141a39e095ea4e37e2653

@SpiritCroc fyi https://gitlab.com/fdroid/fdroiddata/-/commit/0507813723a4551d2eb0428b4454d7bc04e75ecc

I just picked the fix, doing a beta build right now and will likely do a new release within the next few days with it

licaon-kter added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label May 19, 2022

licaon-kter mentioned this issue May 19, 2022

[Release] Element Android v1.4.16 #6078

Closed

61 tasks

bmarty added S-Critical Prevents work, causes data loss and/or has no workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-fdroid F-Droid variant labels May 20, 2022

bmarty added the A-Location label May 20, 2022

ouchadam mentioned this issue May 24, 2022

Excluding the gms play-service-location from maplibre for fdroid builds #6136

Merged

6 tasks

ouchadam closed this as completed in #6136 May 25, 2022

licaon-kter mentioned this issue May 25, 2022

exclude com.google.android.gms from apk binaries deltachat/deltachat-android#2303

Merged

TheLastProject mentioned this issue May 29, 2022

FOSS flavor maplibre/maplibre-native#288

Closed

birkskyum mentioned this issue Sep 18, 2022

Separate build flavor to avoid any references to non-FLOSS software maplibre/maplibre-native#379

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

F-Droid can't build - org.maplibre.gl:android-sdk pulls in non-FOSS Google Services #6100

F-Droid can't build - org.maplibre.gl:android-sdk pulls in non-FOSS Google Services #6100

licaon-kter commented May 19, 2022

licaon-kter commented May 19, 2022

licaon-kter commented May 20, 2022

bmarty commented May 20, 2022 •

edited

Loading

ouchadam commented May 20, 2022

bmarty commented May 20, 2022

licaon-kter commented May 20, 2022

licaon-kter commented May 20, 2022 •

edited

Loading

licaon-kter commented May 20, 2022 •

edited

Loading

bmarty commented May 20, 2022 •

edited

Loading

licaon-kter commented May 20, 2022 •

edited

Loading

bmarty commented May 20, 2022

licaon-kter commented May 25, 2022

ouchadam commented May 25, 2022 •

edited

Loading

licaon-kter commented May 25, 2022

SpiritCroc commented May 25, 2022

F-Droid can't build - org.maplibre.gl:android-sdk pulls in non-FOSS Google Services #6100

F-Droid can't build - org.maplibre.gl:android-sdk pulls in non-FOSS Google Services #6100

Comments

licaon-kter commented May 19, 2022

Steps to reproduce

Outcome

Your phone model

Operating system version

Application version and app store

Homeserver

Will you send logs?

licaon-kter commented May 19, 2022

licaon-kter commented May 20, 2022

bmarty commented May 20, 2022 • edited Loading

ouchadam commented May 20, 2022

bmarty commented May 20, 2022

licaon-kter commented May 20, 2022

licaon-kter commented May 20, 2022 • edited Loading

licaon-kter commented May 20, 2022 • edited Loading

bmarty commented May 20, 2022 • edited Loading

licaon-kter commented May 20, 2022 • edited Loading

bmarty commented May 20, 2022

licaon-kter commented May 25, 2022

ouchadam commented May 25, 2022 • edited Loading

licaon-kter commented May 25, 2022

SpiritCroc commented May 25, 2022

bmarty commented May 20, 2022 •

edited

Loading

licaon-kter commented May 20, 2022 •

edited

Loading

licaon-kter commented May 20, 2022 •

edited

Loading

bmarty commented May 20, 2022 •

edited

Loading

licaon-kter commented May 20, 2022 •

edited

Loading

ouchadam commented May 25, 2022 •

edited

Loading