Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labs flag for enabling live location sharing (PSF-799) #6098

Merged
merged 3 commits into from
May 19, 2022
Merged

Labs flag for enabling live location sharing (PSF-799) #6098

merged 3 commits into from
May 19, 2022

Conversation

onurays
Copy link
Contributor

@onurays onurays commented May 19, 2022

Within this PR, we remove feature flag and add a labs flags for live location sharing.

Labs

@onurays onurays requested review from a team, ouchadam and ariskotsomitopoulos and removed request for a team May 19, 2022 09:17
ouchadam
ouchadam approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@ouchadam
Copy link
Contributor

do we need a changelog entry?

ouchadam
ouchadam reviewed May 19, 2022
View reviewed changes
vector/src/main/java/im/vector/app/features/VectorFeatures.kt
@@ -26,7 +26,6 @@ interface VectorFeatures {
fun isOnboardingUseCaseEnabled(): Boolean
fun isOnboardingPersonalizeEnabled(): Boolean
fun isOnboardingCombinedRegisterEnabled(): Boolean
fun isLiveLocationEnabled(): Boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR, in the future I could imagine sharing the VectorFeatures with the lab features and having a single point of truth for toggling features

onurays added 2 commits May 19, 2022 12:44
@onurays
Changelog added.
5b43257
@onurays
Merge branch 'develop' into live_location_labs_flag
2e2dffd 
* develop:
  Space explore rooms screen alignment with design in figma (#5834)
  leaving space aligned with ios (#5942)
  Fix usage of System.currentTimeMillis(). This a bit mocky but anyway it's better to use SystemClock.elapsedRealtime() for this case.
@github-actions
Copy link

Unit Test Results

122 files  122 suites   2m 8s ⏱️
205 tests 205 ✔️ 0 💤 0 ❌
690 runs  690 ✔️ 0 💤 0 ❌

Results for commit 2e2dffd.

@onurays onurays merged commit c518f59 into develop May 19, 2022
@onurays onurays deleted the live_location_labs_flag branch May 19, 2022 10:54
@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    = passed=20 failures=0 errors=0 skipped=3
  • [org.matrix.android.sdk.account]
    = passed=3 failures=0 errors=0 skipped=2
  • [org.matrix.android.sdk.internal]
    = passed=5 failures=1 errors=0 skipped=0
  • [org.matrix.android.sdk.ordering]
    = passed=16 failures=0 errors=0 skipped=0
  • [org.matrix.android.sdk.PermalinkParserTest]
    = passed=2 failures=0 errors=0 skipped=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ouchadam ouchadam ouchadam approved these changes

@ariskotsomitopoulos ariskotsomitopoulos Awaiting requested review from ariskotsomitopoulos ariskotsomitopoulos was automatically assigned from element-hq/element-android-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurays @ouchadam