Feature/bma/sdk sync service #6029
Conversation
bmarty
force-pushed
the
feature/bma/sdk_sync_service
branch
from
4448255 to
6e86b02
Compare
| override fun startSync(fromForeground: Boolean) { | ||
| Timber.i("Starting sync thread") | ||
| // TODO How to check that now? | ||
| // assert(isOpen) |
There was a problem hiding this comment.
Is it OK to not do this check anymore? See the TODO.
There was a problem hiding this comment.
For SyncService.doSync (SyncAndroidService now) this assert worked as exit condition. AssertionError was caught and handled and now it won't. Do we know how often it happens? And what will happen if we'll try to start sync without open session - will it fail before network request or will be executed? We shouldn't execute a request if there is no chance that it will result with success 🤔
There was a problem hiding this comment.
You are right. Improved in a33f7d0 which restores the previous checks.
|
|
||
| override fun stopSync() { | ||
| // TODO How to check that now? | ||
| // assert(isOpen) |
There was a problem hiding this comment.
Is it OK to not do this check anymore? See the TODO.
bmarty
requested review from
a team,
Claire1817 and
fedrunov
and removed request for
a team
|
Thanks for the review. I will rebase to fix all the conflicts, and merge it. |
Merge SyncStatusService to SyncService, and rename some classes
bmarty
force-pushed
the
feature/bma/sdk_sync_service
branch
from
a33f7d0 to
ac61aee
Compare
|
SonarCloud Quality Gate failed. |
Type of change
Content
First point of #5864
Motivation and context
Improve SDK API
Screenshots / GIFs
Tests
Tested devices
Checklist