Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added themed icon for Android 13 #5936

Merged
merged 6 commits into from
May 11, 2022
Merged

Added themed icon for Android 13 #5936

merged 6 commits into from
May 11, 2022

Conversation

hanthor
Copy link
Contributor

@hanthor hanthor commented May 4, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Added support for themed icons in Android 13. Folled guidance from here: https://developer.android.com/about/versions/13/features#themed-app-icons

Motivation and context

Element current does not display with a themed icon in android 12 and 13

Screenshots / GIFs

image

Tested devices

  • [x ] Physical
  • [x ] Emulator
  • OS version(s): 13 beta 1

Checklist

Signed-off-by: James Reilly [email protected]

@hanthor
Copy link
Contributor Author

hanthor commented May 4, 2022

I added the monochrome entry to both roung and regular icons due to the note here:

Note: If android:roundIcon and android:icon are both in your manifest, you must either remove the reference to android:roundIcon or supply the monochrome icon in the drawable defined by the android:roundIcon attribute.

@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label May 5, 2022
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Can you add a sign off please? Then I will be able to merge it.
See https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off

@hanthor
Copy link
Contributor Author

hanthor commented May 11, 2022

Signed off

@bmarty bmarty merged commit cd509ac into element-hq:develop May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants