Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Live location sharing] - Removing BeaconInfo structure #5814

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

mnaturel
Copy link
Contributor

@mnaturel mnaturel commented Apr 21, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Updating the beacon state event content sent during a live location share. Some fields are no longer encapsulated into an extra data layer.
Fixing state event content sent when stopping a live: only the "live" field is updated.

Motivation and context

See MSC-3672

Screenshots / GIFs

Tests

Ensure to enable location sharing in Preferences and the live location feature flag in developer settings.

  • Start a live location share into a room
  • Check you see the start message of the live

Note: other live status are not currently handled (e.g. location data, stopped)

Tested devices

  • Physical
  • Emulator
  • OS version(s): 11

Checklist

@github-actions
Copy link

github-actions bot commented Apr 21, 2022

Unit Test Results

114 files  ±0  114 suites  ±0   1m 23s ⏱️ -2s
202 tests ±0  202 ✔️ ±0  0 💤 ±0  0 ±0 
678 runs  ±0  678 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit eb84475. ± Comparison against base commit 8eaa2f8.

♻️ This comment has been updated with latest results.

@mnaturel mnaturel requested review from a team and ariskotsomitopoulos and removed request for a team April 21, 2022 14:48
@mnaturel mnaturel marked this pull request as ready for review April 21, 2022 15:34
Copy link
Contributor

@ariskotsomitopoulos ariskotsomitopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it seems fine to me

@mnaturel mnaturel merged commit 343322e into develop Apr 26, 2022
@mnaturel mnaturel deleted the fix/mna/live-location-beacon-format branch April 26, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants