Formats project with new code style #5805
Conversation
| if (isTracking) { | ||
| val translationY = event.y - startY | ||
| swipeView.translationY = translationY | ||
| onSwipeViewMove(translationY, translationLimit) | ||
| } | ||
| return true | ||
| } | ||
| else -> { | ||
| else -> { |
There was a problem hiding this comment.
I do not understand why we have so many changes.
The plan was to change the rules one by one.
So:
- create the .editorconfig with the current rules, eventually format the whole code base to fix existing issues.
- Change the rules one by one, in .editorconfig and then format, so for instance, change the rule for
arrow alignmentand see in the PR only changes about the arrows.
WDYT?
There was a problem hiding this comment.
The format here is actually without any rule changes. The problem we're facing is the app doesn't consistently abide by our currently set rules and breaks many basic lint rules in lots of places.
Update: By not using editor config (i.e. using android studio format settings), I was able to massively reduce the diff. This is the smallest autoformat I can do on the whole project so that the code style (reflecting the current) is consistent all around
There was a problem hiding this comment.
The current rule is to align the arrows in a when block vertically and here it is changing, so I do not understand.
There was a problem hiding this comment.
(Updated the PR fixing this. This file no longer has any diffs)
ericdecanini
force-pushed
the
task/eric/format-project
branch
from
03aa7f7 to
de899bb
Compare
Type of change
Content
Autoformats project
Motivation and context
Aligns project with new editorconfig standards
This is to prepare for incremental code style changes, and should be the only PR in the code style subproject with a massive diff, thus the greatest challenge.
I tested conflicts for this by merging this branch into the Tchap fork and this seemed to introduce only a few more easy-to-resolve conflicts than there would be when merging with develop
See also #5644
Screenshots / GIFs
N/A
Tests
You will see that there are a lot of conflicts, but most of these conflicts come from changes that are on our repo's develop and not the changes on this branch specifically. If you repeat the steps above but instead merge upstream/develop into origin/develop, you will see that most of those conflicts are still present and this branch adds only few.
Tested devices
Checklist