Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting transfer title #5765

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

chagai95
Copy link
Contributor

@chagai95 chagai95 commented Apr 14, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fixing setting transfer title in call transfer.

Motivation and context

It was showing the app title (e.g. Element) instead of the app:title (the title of MaterialToolbar)

Screenshots / GIFs

Before After
image image

Tests

  • called someone
  • transferred call
  • looked at title

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Signed-off-by: Chagai Friedlander [email protected]

@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Apr 14, 2022
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit c58b8ac into element-hq:develop Apr 14, 2022
@chagai95 chagai95 deleted the fix-setting-transfer-title branch April 15, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants