Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for communities/groups #5733

Closed
2 of 6 tasks
kittykat opened this issue Apr 11, 2022 · 4 comments · Fixed by #6268
Closed
2 of 6 tasks

Remove support for communities/groups #5733

kittykat opened this issue Apr 11, 2022 · 4 comments · Fixed by #6268
Assignees
Labels
A-Groups O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@kittykat
Copy link
Contributor

kittykat commented Apr 11, 2022

Communities have been deprecated so they should be removed from the app.

Tasks

  • Estimate this issue
  • Announce to users who have communities enabled that they will be removed with the next release
  • Remove support for communities
  • Add copy for when a user tries to access a community (e.g. through a matrix.to link)
  • Compile a list of potential areas of the app that are touched as part of the coding work
  • Run a regression testing session to confirm that the removal of communities does not break anything else

References

@kittykat kittykat added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 11, 2022
@fedrunov
Copy link
Contributor

groups will be disabled/removed from the backend in aprox. 3 weeks from now, so we don't have time to prepare a release with migration tool or announcement

some entry points for groups will still present after removal (e.g. links in timeline) so we need somehow to inform user that feature was removed, e.g. via popup and we need design/description of how it should look like along with the string resources and images if necessary

@novocaine novocaine added the X-Needs-Design May require input from the design team label Apr 12, 2022
@kittykat
Copy link
Contributor Author

kittykat commented Apr 12, 2022

Copy to show when a user tries to open a community link:

That link is no longer supported.
You're trying to access a link to a community (+community:matrix.org). Communities are no longer supported and have been replaced by spaces. Learn more about spaces here.

+community:matrix.org should be replaced by correct link

References

Here is an example matrix.to link to a community: https://develop.element.io/#/group/+community:matrix.org

0618a601-c4d7-44ff-bec4-a21d61f1b8ad

@kittykat kittykat removed the X-Needs-Design May require input from the design team label Apr 12, 2022
@fedrunov fedrunov mentioned this issue Jun 9, 2022
15 tasks
@kittykat
Copy link
Contributor Author

@fedrunov Try this error message:

Cannot open this link: communities are no longer supported and have been replaced by spaces.

@fedrunov
Copy link
Contributor

After discussion with @kittykat it was decided that to be consistent with current link errors handling we should show just a toast message, instead of fullscreen error like on web.

Screenshot 2022-06-10 at 15 39 13

NOTE: default icon looks to be android's bug:

https://issuetracker.google.com/issues/202863198?pli=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Groups O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants