Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wrongly show non-space invites in the space panel #5731

Merged
merged 4 commits into from
Apr 13, 2022
Merged

Don't wrongly show non-space invites in the space panel #5731

merged 4 commits into from
Apr 13, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 11, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Prevents invites to non-space non-null room types from showing up wrongly in the Space panel

Motivation and context

Screenshots / GIFs

Before After
image image

Tests

  • Invited test account to video room
  • Checked if invite was (wrongly) visible in the space panel

Tested devices

  • Physical
  • Emulator
  • OS version(s): API 22

Checklist

@t3chguy t3chguy requested review from a team and onurays and removed request for a team April 11, 2022 10:38
@t3chguy t3chguy added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Apr 11, 2022
onurays
onurays suggested changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is gradle-wrapper.properties changes accidental instead of changelog?

@t3chguy t3chguy requested a review from onurays April 11, 2022 13:56
onurays
onurays approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have lack of knowledge about space :) Let me ask someone else to review too.

BillCarsonFr
BillCarsonFr requested changes Apr 12, 2022
View reviewed changes
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could probably juste use spaceSummaryQueryParams {

vector/src/main/java/im/vector/app/features/spaces/SpaceListViewModel.kt Outdated Show resolved Hide resolved
@t3chguy t3chguy requested a review from BillCarsonFr April 12, 2022 13:43
bmarty
bmarty approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@bmarty bmarty merged commit 2761b35 into element-hq:develop Apr 13, 2022
@t3chguy t3chguy deleted the t3chguy/fix-room-type-misuse branch April 13, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@onurays onurays onurays approved these changes

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr

Assignees
No one assigned
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t3chguy @onurays @bmarty @BillCarsonFr