Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bma/avoid error log #5703

Merged
merged 10 commits into from
Apr 6, 2022
Merged

Feature/bma/avoid error log #5703

merged 10 commits into from
Apr 6, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 6, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • When displaying the detail of any non location event, we got some errog log because the code was trying to parse a location Event
  • When there is not keybackup configure, we get a 404 with noisy exception stacktrace. This PR change the API to have a better handling of this error.

Motivation and context

Polluted error logs

Screenshots / GIFs

No visual change

Tests

  • Long press on a regular message
  • Observe the error logs

Tested devices

  • Physical
  • Emulator
  • OS version(s):

@bmarty bmarty marked this pull request as draft April 6, 2022 09:46
@github-actions
Copy link

github-actions bot commented Apr 6, 2022 •
edited
Loading

Unit Test Results

110 files  ±0  110 suites  ±0   1m 18s ⏱️ -2s
195 tests ±0  195 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
650 runs  ±0  650 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7cbe77e. ± Comparison against base commit c849cc5.

♻️ This comment has been updated with latest results.

@bmarty bmarty marked this pull request as ready for review April 6, 2022 10:50
@bmarty bmarty requested review from a team and fedrunov and removed request for a team April 6, 2022 10:50
@bmarty bmarty enabled auto-merge April 6, 2022 12:59
@bmarty bmarty merged commit 9c1cdf6 into develop Apr 6, 2022
@bmarty bmarty deleted the feature/bma/avoid_error_log branch April 6, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedrunov fedrunov fedrunov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarty @fedrunov