Show a banner in timeline while location sharing service is running #5660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results110 files ±0 110 suites ±0 1m 18s ⏱️ +3s Results for commit 5ec6385. ± Comparison against base commit 539d198. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
onurays
requested review from
a team and
ariskotsomitopoulos
and removed request for
a team
| @@ -482,6 +482,8 @@ class TimelineFragment @Inject constructor( | |||
| RoomDetailViewEvents.StopChatEffects -> handleStopChatEffects() | |||
| is RoomDetailViewEvents.DisplayAndAcceptCall -> acceptIncomingCall(it) | |||
| RoomDetailViewEvents.RoomReplacementStarted -> handleRoomReplacement() | |||
| RoomDetailViewEvents.ShowLocationSharingIndicator -> handleShowLocationSharingIndicator() | |||
There was a problem hiding this comment.
To simplify the code and not to add more lines in TImelineFragment while its already huge, I would have one Event ShowLocationSharingIndicator instead of two:
handleShowLocationSharingIndicator(show: Boolean){
views.locationLiveStatusIndicator.isVisible = show
}
There was a problem hiding this comment.
Right, as we discussed internally. Done.
ariskotsomitopoulos
approved these changes
Apr 4, 2022
Thank you, we will create another PR to support threads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have already implemented the banner previously. This PR handles the visibility of the banner by observing the location service lifecycle.