Align Autorageshake with web implementation

[langleyd]

Fixes #5596

[github-actions]

Unit Test Results

114 files  +  8  114 suites  +8   1m 36s ⏱️ +3s
201 tests +13  201 ✔️ +13  0 💤 ±0  0 ❌ ±0 
674 runs  +52  674 ✔️ +52  0 💤 ±0  0 ❌ ±0 

Results for commit 363afd0. ± Comparison against base commit 1097436.

This pull request removes 2 and adds 15 tests. Note that renamed tests count towards both.

im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given registration has started and has dummy step to do, when handling action, then ignores other steps and executes dummy
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ when registering account, then updates state and emits account created event

im.vector.app.features.onboarding.DirectLoginUseCaseTest ‑ given direct authentication throws, when logging in directly, then returns failure result with original cause
im.vector.app.features.onboarding.DirectLoginUseCaseTest ‑ given wellknown fails with content, when logging in directly, then returns success with direct session result
im.vector.app.features.onboarding.DirectLoginUseCaseTest ‑ given wellknown fails without content, when logging in directly, then returns well known error
im.vector.app.features.onboarding.DirectLoginUseCaseTest ‑ given wellknown throws, when logging in directly, then returns failure result with original cause
im.vector.app.features.onboarding.DirectLoginUseCaseTest ‑ when logging in directly, then returns success with direct session result
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given has sign in with matrix id sign mode, when handling login or register action fails, then emits error
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given has sign in with matrix id sign mode, when handling login or register action, then logs in directly
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given personalisation enabled and registration has started and has dummy step to do, when handling action, then ignores other steps and executes dummy
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given personalisation enabled, when registering account, then updates state and emits account created event
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given when editing homeserver, then updates selected homeserver state and emits edited event
…

♻️ This comment has been updated with latest results.

[bmarty]

I'll defer to @BillCarsonFr review for the content of the change.
Just one remark about the changelog (a PR can have multiple changelog files)

[BillCarsonFr]

This is not exaclty what we want no? Looks a bit strange. Also we are subscribing to the flow for the all session lifecycle no?

[langleyd]

"For the lifetime of the session, confirm we are not in an initial sync", Being outside an initial sync I thought would be reasonably equivalent to after an initial sync.

Web uses the sync token, so equivalent to hasAlreadySynced. We could keep a reference to the active sessions and call hasAlreadySynced synchronously in enabled?

[BillCarsonFr]

@ganfra or @bmarty what would be the best way to check that an initial sync has already been done?

[bmarty]

I think this is acceptable.
Maybe we should rename SyncStatusService.Status.Progressing to SyncStatusService.Status.InitialSyncProgressing for clarity.

It's historical, previously we did not track the incremental sync status.

[bmarty]

LGTM