Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Android stem 2.0.0 #5348

Merged
merged 5 commits into from
Feb 24, 2022
Merged

Upgrade to Android stem 2.0.0 #5348

merged 5 commits into from
Feb 24, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 24, 2022

Fixes #5341

Upgrade the dependency to generate strings using template.

It requires changing lots of strings key. But Weblate is currently locked, so this is fine.

1st and 3rd commit are interesting, the 2nd one is basically replacing <string name="template_ by <string name=" everywhere.

Tested OK on this screen for instance, where title and subtitle contains a template:

image

bmarty and others added 4 commits February 24, 2022 15:25
…d.android:string-reference:1.2.2` to `com.likethesalad.android:stem-plugin:2.0.0`
Template and no template version was present, it was a mistake.
Copy link
Contributor

@ariskotsomitopoulos ariskotsomitopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its seems fine to me

@bmarty bmarty enabled auto-merge February 24, 2022 15:37
@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed="25" failures="17" errors="0" skipped="2"
  • [org.matrix.android.sdk.account]
    passed="5" failures="0" errors="0" skipped="2"
  • [org.matrix.android.sdk.internal]
    passed="158" failures="13" errors="0" skipped="38"
  • [org.matrix.android.sdk.ordering]
    passed="16" failures="0" errors="0" skipped="0"
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed="2" failures="0" errors="0" skipped="0"

@github-actions
Copy link

Unit Test Results

  84 files  ±0    84 suites  ±0   1m 0s ⏱️ -4s
157 tests ±0  157 ✔️ ±0  0 💤 ±0  0 ±0 
504 runs  ±0  504 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 5895c69. ± Comparison against base commit b226ab5.

@bmarty bmarty merged commit a1f5493 into develop Feb 24, 2022
@bmarty bmarty deleted the feature/android-stem_2.0.0 branch February 24, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to LikeTheSalad/android-stem 2.0.0
2 participants