Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5289: Moves modules to subfolders under library #5309

Merged
merged 4 commits into from
Feb 22, 2022

Conversation

ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Feb 22, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Moves these modules to subfolders under library: (were previously modules at project root)

  • attachment-viewer
  • diff-match-patch
  • multipicker

Motivation and context

Closes #5289

Screenshots / GIFs

Tests

Smoke test app

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed=
  • [org.matrix.android.sdk.account]
    passed=
  • [org.matrix.android.sdk.internal]
    passed=
  • [org.matrix.android.sdk.ordering]
    passed=
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed=

@github-actions
Copy link

Unit Test Results

  84 files  ±0    84 suites  ±0   55s ⏱️ -14s
157 tests ±0  157 ✔️ ±0  0 💤 ±0  0 ±0 
504 runs  ±0  504 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 44452c9. ± Comparison against base commit bff663d.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty marked this pull request as ready for review February 22, 2022 21:58
@bmarty bmarty merged commit 924a4f8 into develop Feb 22, 2022
@bmarty bmarty deleted the feature/eric/modules-to-subfolder branch February 22, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move modules to subfolder
2 participants