Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise configuration options for emulators in GHA integration tests #5210

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

michaelkaye
Copy link
Contributor

This makes it easier to reason about emulator failures.

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Update sanity_test.yml to use same configuration options when running an emulator as integration_test.yml

Motivation and context

We've had issues with the emulator not starting; using the same options in both places will make it easier to reason about

Screenshots / GIFs

N/A

Tests

#5193 contains some experiments - the build there is currently passing.

I'm aware that the builds may be fragile at present, and merging this PR is not guaranteed to fix the UiSanityTests

Tested devices

N/A

Checklist

@michaelkaye michaelkaye changed the title Make sanity_test.yml use same configuration as integration_test.yml Standardise configuration options for emulators in GHA integration tests Feb 11, 2022
@github-actions
Copy link

Unit Test Results

  76 files  ±0    76 suites  ±0   59s ⏱️ +2s
144 tests ±0  144 ✔️ ±0  0 💤 ±0  0 ±0 
452 runs  ±0  452 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit d173a8d. ± Comparison against base commit ea13f1c.

@michaelkaye michaelkaye marked this pull request as ready for review February 11, 2022 16:20
@github-actions
Copy link

github-actions bot commented Feb 11, 2022

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed="25" failures="15" errors="0" skipped="2"
  • [org.matrix.android.sdk.account]
    passed="1" failures="1" errors="0" skipped="0"
  • [org.matrix.android.sdk.internal]
    passed="1" failures="1" errors="0" skipped="0"
  • [org.matrix.android.sdk.ordering]
    passed="1" failures="1" errors="0" skipped="0"
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed="1" failures="1" errors="0" skipped="0"

Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this, the test action logs look really promising! 🤞

@ouchadam ouchadam merged commit d6a08a9 into develop Feb 11, 2022
@ouchadam ouchadam deleted the michaelk/standardise_emulator_usage branch February 11, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants