Small iteration on command parser #4998

bmarty · 2022-01-19T20:10:24Z

Small cleanup on this part of the code + add some unit tests.

Not all commands are covered, could add more tests later.

github-actions · 2022-01-19T20:40:47Z

Unit Test Results

  72 files +  4   72 suites +4 51s ⏱️ -3s
141 tests +  5 141 ✔️ +  5 0 💤 ±0 0 ❌ ±0
440 runs +20 440 ✔️ +20 0 💤 ±0 0 ❌ ±0

Results for commit e9f9c7e. ± Comparison against base commit 491044b.

github-actions · 2022-01-19T22:37:52Z

[org.matrix.android.sdk.session]
passed="21" failures="0" errors="0" skipped="2"
[org.matrix.android.sdk.account]
passed="5" failures="0" errors="0" skipped="2"
[org.matrix.android.sdk.internal]
passed="158" failures="12" errors="0" skipped="38"
[org.matrix.android.sdk.ordering]
passed="16" failures="0" errors="0" skipped="0"
[org.matrix.android.sdk.PermalinkParserTest]
passed="2" failures="0" errors="0" skipped="0"

bmarty added 5 commits January 19, 2022 18:43

Command parser is not a static object anymore

eb4475b

Small cleanup

4f1de34

use sealed interface

87adaee

data class.

c7dc08e

Add some unit test for the command parser.

6710f93

Not all commands are covered, could add more tests later.

bmarty requested a review from fedrunov January 19, 2022 20:10

Changelog

e9f9c7e

bmarty changed the title ~~Small iteraction on command parser~~ Small iteration on command parser Jan 19, 2022

fedrunov approved these changes Jan 20, 2022

View reviewed changes

bmarty merged commit 01ff85d into develop Jan 20, 2022

bmarty deleted the feature/bma/command_parser branch January 20, 2022 09:30