Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude dependabot upgrade for @github-script@v3 #4988

Closed
ariskotsomitopoulos opened this issue Jan 19, 2022 · 3 comments · Fixed by #4989
Closed

Exclude dependabot upgrade for @github-script@v3 #4988

ariskotsomitopoulos opened this issue Jan 19, 2022 · 3 comments · Fixed by #4989
Assignees
@ariskotsomitopoulos
Labels
A-Developer-Experience

Comments

@ariskotsomitopoulos
Copy link
Contributor

ariskotsomitopoulos commented Jan 19, 2022 •
edited
Loading

Newest @github-script 5.x.x versions removed functions for comment deletion
@ariskotsomitopoulos ariskotsomitopoulos self-assigned this Jan 19, 2022
@ariskotsomitopoulos ariskotsomitopoulos mentioned this issue Jan 19, 2022
Merged
@bmarty
Copy link
Member

bmarty commented Jan 19, 2022

What wrong with version 5.x.x ? I would required some code migration?

@ariskotsomitopoulos
Copy link
Contributor Author

This issue is just for v3, to exclude updates. Nothing wrong with 5.x.x just missing a function for comment deletion. Check the PR

@bmarty
Copy link
Member

bmarty commented Jan 19, 2022

I see your point now, thanks!

@bmarty bmarty mentioned this issue Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariskotsomitopoulos ariskotsomitopoulos

Labels
A-Developer-Experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore dependabot upgrade for @github-script@v3 element-hq/element-android
2 participants
@bmarty @ariskotsomitopoulos