Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ShareCompat.IntentBuilder for sharing content #4745

Merged
merged 3 commits into from
Jan 3, 2022
Merged

Use ShareCompat.IntentBuilder for sharing content #4745

merged 3 commits into from
Jan 3, 2022

Conversation

johnjohndoe
Copy link
Contributor

@johnjohndoe johnjohndoe commented Dec 17, 2021 •
edited
Loading

Description

  • The implementation of sharing text and sharing media is updated to use the ShareCompat.IntentBuilder API.
  • The UI does not change.

Pull Request Checklist

Screenshots

  • Screenshot of the system share chooser UI for sharing a file.
    share-file
  • Screenshot of the system share chooser UI for sharing an image.
    share-image
  • Screenshot of the system share chooser UI for sharing plain text.
    share-text

@johnjohndoe johnjohndoe marked this pull request as ready for review December 17, 2021 08:10
bmarty
bmarty reviewed Dec 30, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Can you add a file for the changelog and a sign-off please? You'll find more information about that in https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md

vector/src/main/java/im/vector/app/core/utils/ExternalApplicationsUtil.kt Outdated Show resolved Hide resolved
vector/src/main/java/im/vector/app/core/utils/ExternalApplicationsUtil.kt Outdated Show resolved Hide resolved
@johnjohndoe
Use property access syntax.
5fd3317 
Signed-off-by: Tobias Preuss <[email protected]>
@johnjohndoe
Use ShareCompat.IntentBuilder in "shareText()" utility function.
70b0747 
Signed-off-by: Tobias Preuss <[email protected]>
@johnjohndoe
Let ShareCompat.IntentBuilder create the chooser intent for sharing c…
74363ff 
…ontent.

+ Although the system's intent chooser normally takes care of cases when
  no app is found we still keep the safeguard here to be prepared for
  exotic devices behaving different.

Signed-off-by: Tobias Preuss <[email protected]>
bmarty
bmarty approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will rename createChooser to safeStartActivity which is more appropriate I think

@bmarty bmarty merged commit 9534abe into element-hq:develop Jan 3, 2022
@johnjohndoe johnjohndoe deleted the sharecompat branch January 3, 2022 15:22
@bmarty bmarty mentioned this pull request Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnjohndoe @bmarty