Fix possible crash when having identical subspaces in multiple root spaces

[SpiritCroc]

When you have two root spaces with the same space as subspace, and you expand both root spaces, you end up with two times the same id in the list. This has two problems:

• The expand animation is slightly broken, if you expand the second root space first and then the first one
• If you select one of these items with same id, the app crashes:
  java.lang.IllegalStateException: Two different ViewHolders have the same stable ID. Stable IDs in your adapter MUST BE unique and SHOULD NOT change.

As solution, just prefix the epoxy item ids with the parent spaces.

Signed-off-by: Tobias Büttner [email protected]

Pull Request Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[ouchadam]

small nit pick - it could help make this a little easier to understand if we highlight the parent/child space relationship
what do you think?

fun buildSubSpace(parentId: String) {
  val id = "$parent:$child"

  spaceSummaryItem {
    id(id)
  }

  subSpaces.forEach { child ->
    buildSubSpace(parent = id)
  }
}

[ouchadam]

great find! 👍

[bmarty]

Thanks!